Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional RPCS3 patch file creation #40

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Functional RPCS3 patch file creation #40

merged 2 commits into from
Nov 11, 2023

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented Nov 10, 2023

This really is not the cleanest code ive ever written, im not the happiest with this, but i struggled to refactor this into anything better, so i left the structure mostly as is

This really is not the cleanest code ive ever written, im not the happiest with this, but i struggled to refactor this, so i left the structure *mostly* as is
@Beyley Beyley requested a review from jvyden November 10, 2023 05:09
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some UX concerns and the usual minor code quality nitpicks.

Refresher/Patching/EbootPatcher.cs Outdated Show resolved Hide resolved
Refresher/Patching/EbootPatcher.cs Outdated Show resolved Hide resolved
Refresher/Patching/EbootPatcher.cs Outdated Show resolved Hide resolved
Refresher/UI/EmulatorPatchForm.cs Outdated Show resolved Hide resolved
@Beyley Beyley requested a review from jvyden November 10, 2023 23:33
@jvyden jvyden merged commit d3648bc into main Nov 11, 2023
4 checks passed
@jvyden jvyden deleted the rpcs3-patch-files branch August 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants